Skip to content

feat: service router applied (project) #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2025
Merged

feat: service router applied (project) #5774

merged 8 commits into from
Apr 16, 2025

Conversation

skdud4659
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

SSIA

Things to Talk About (optional)

@skdud4659 skdud4659 added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Apr 15, 2025
@skdud4659 skdud4659 requested a review from piggggggggy April 15, 2025 16:15
@vercel Vercel
Copy link

vercel bot commented Apr 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 8:19am
dashboard ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 8:19am
web-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 8:19am

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2025

@skdud4659 is attempting to deploy a commit to the cloudforet Team on Vercel.

A member of the Team first needs to authorize it.

@piggggggggy piggggggggy requested a review from Copilot April 16, 2025 01:42
Copilot
Copilot AI reviewed Apr 16, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

@skdud4659 skdud4659 merged commit 5e9d617 into cloudforet-io:feature-integration-project-detail Apr 16, 2025
7 of 8 checks passed
@skdud4659 skdud4659 deleted the feature/service-route branch April 16, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@piggggggggy piggggggggy Awaiting requested review from piggggggggy

Assignees
No one assigned
Labels
pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skdud4659